escape backslashes in JS string literal output#1164
Open
digi-scrypt wants to merge 1 commit into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
\right against the closing quote the printer adds and breaks out of the JS string literal.srcmetadata, all built from attribute values in the source.A quoted attribute is the trigger.
<Component path='C:\dir\' />currently emits{"path":"C:\dir\"}which node refuses to parse; a crafted trailing backslash terminates the string early and the following bytes are no longer inside it. Same story forsrcon a hoisted<script>.Escaped the backslash first in both helpers. The one place escapeNewlines wraps the value I flipped the order so the
\nit inserts isn't doubled. Added a snapshot covering a backslash attribute.