fix(go): update module path to v5#523
Merged
Merged
Conversation
The v5.x release line was tagged without bumping the Go module path in go.mod, which still declared .../v4. This breaks `go get` for the v5 module path and downstream consumers (notably the Pulumi Terraform bridge). Update the module path and all import references from /v4 to /v5. Follow-up to vercel#429 (v3 -> v4) and vercel#227 (v1 -> v2).
omercnet
requested review from
craigandrews,
dglsparsons,
ecklf,
jarneson and
kitfoster
as code owners
Member
|
The tests are failing :ohno: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #522.
What
Bumps the Go module path from
…/v4to…/v5to match the publishedv5.xtags, as required by Go semantic import versioning.go.modmodule path…/v4→…/v5134internal.goimport statements…/v4→…/v5.goreleaser.ymlldflagsversion-injection path…/v4/client.version→…/v5/client.version136 files changed, mechanical path-only edit — no dependency or logic changes (
go.sumuntouched).Why
The whole
v5.xline (v5.0.0…v5.3.0) shipped withgo.modstill declaring…/v4, so the module is uninstallable at its own major version:This breaks downstream Go consumers — most importantly the Pulumi Terraform bridge /
pulumi-vercel, the same consumer behind the Pulumi-compat work in #430.Verification
go build ./...— exit 0go vet ./...— exit 0gofmt -l .— emptygo mod verify— all modules verifiedgit grep terraform-provider-vercel/v4— 0 matches remainingA gentle ask 🙏
This is the third time the module path has lagged a major release — I previously fixed v3→v4 in #429, and it was v1→v2 in #227. Each miss breaks the Pulumi bridge until it's patched. Could we please keep the
/vNsuffix tidy as part of the release process — ideally a CI guard that asserts thego.modmajor suffix matches the tag — so this doesn't recur on v6? Happy to send that guard as a follow-up if useful.