fix: warn on undeclared shorthand event handlers on svelte:window/document/body#18480
Open
chatman-media wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 0ba0e76 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a regular element, writing a shorthand event handler whose name isn't declared (e.g.
{onresize}) gives you theattribute_global_event_referencewarning, since it quietly falls back to the global handler. But<svelte:window>,<svelte:document>and<svelte:body>never ran that check, so the same typo there slipped by silently — closes #18275.I pulled the shorthand-identifier check into a small helper in
special-element.jsand call it from the three special-element visitors for their event attributes. Spread/non-event attributes still error exactly as before. Added a validator sample covering all three (a declared handler stays quiet, undeclared ones warn).