fix: Fixes error thrown on use of select with no options#18449
Open
kaushikashok45 wants to merge 4 commits into
Open
fix: Fixes error thrown on use of select with no options#18449kaushikashok45 wants to merge 4 commits into
kaushikashok45 wants to merge 4 commits into
Conversation
🦋 Changeset detectedLatest commit: 861adde The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Author
|
Hi, this PR resolves #18445 and passes all local testing. Ready for your review when you have a moment! @Rich-Harris |
dummdidumm
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this solve?
Fixes #18445.
Any sibling element or text node placed after a
<select>with avalueattribute caused the Svelte compiler to crash with:The error originates inside
esrapduring code generation, because the compiler was emitting a malformed AST node (e.objectwasnull) for thevalueattribute on<select>.Minimal repro:
Root cause
The guard that short-circuits attribute handling for two-way bindable properties (
value,checked) only coveredinputandtextarea— it did not includeselect. As a result, when a<select value="...">appeared with a sibling, the compiler fell through to a code path that produced a broken AST.Fix
Expanded the node name check to also include
'select':This ensures
<select value="...">is handled consistently with<input value="...">and<textarea value="...">.