fix: avoid NaN keyframe values in slide transition#18430
Open
Nic-Polumeyv wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: a2243be The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14205
When a
slidetransition runs on an element without a layout box, for example inside adisplay: noneparent,getComputedStylereturns values likeautofor the animated dimensions. These were passed throughparseFloatunguarded, so the generated css containedheight: NaNpxand the browser rejected the keyframe property with an "Invalid keyframe value" warning on every transition.Svelte 4 had the same
NaNbut never surfaced it, because invalid declarations in injected stylesheet rules are silently dropped, while the Web Animations API validates keyframes and warns.This treats unparseable computed dimensions as
0. The user visible result is the same as today (the browser was already discarding the invalid property, and an element with no layout box has nothing to slide), minus the console spam.feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset)Tests and linting
pnpm testand lint the project withpnpm lint