Skip to content

Fix rustc --unpretty=expanded emit of [const] [unsafe] impl Trait for#158600

Open
Arnavion wants to merge 1 commit into
rust-lang:mainfrom
Arnavion:unpretty-const-impl-trait-keyword-order
Open

Fix rustc --unpretty=expanded emit of [const] [unsafe] impl Trait for#158600
Arnavion wants to merge 1 commit into
rust-lang:mainfrom
Arnavion:unpretty-const-impl-trait-keyword-order

Conversation

@Arnavion

@Arnavion Arnavion commented Jun 30, 2026

Copy link
Copy Markdown

Fixes #158599

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 30, 2026
@rustbot

rustbot commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @JonathanBrouwer (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue
Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 17 candidates

@rustbot

This comment has been minimized.

@Arnavion Arnavion force-pushed the unpretty-const-impl-trait-keyword-order branch from 055c827 to 121f01b Compare June 30, 2026 04:32
@Arnavion

Copy link
Copy Markdown
Author

FYI this is my first contribution to this repo. I've done x build library and x test per https://rustc-dev-guide.rust-lang.org/building/how-to-build-and-run.html , and used the stage1 rustc to test the repro in the linked issue as well as my real code that triggered this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rustfmt chokes on "impl const Trait" output by rustc --unpretty=expanded

3 participants