gh-152519: fix(email): don't decode RFC 2047 encoded-words in addr-spec local-parts#152520
Closed
muhamedfazalps wants to merge 2 commits into
Closed
gh-152519: fix(email): don't decode RFC 2047 encoded-words in addr-spec local-parts#152520muhamedfazalps wants to merge 2 commits into
muhamedfazalps wants to merge 2 commits into
Conversation
RFC 2047 §5 forbids encoded-words in addr-spec. The current parser decodes them anyway via get_dot_atom(), corrupting address parsing when the decoded text contains address-special characters like '@'. Fix: add ew_allowed parameter to get_dot_atom() (default True for backward compatibility). Pass ew_allowed=False when parsing local-parts inside addr-spec to prevent encoded-word decoding. Fixes python#152519
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
All commit authors signed the Contributor License Agreement. |
muhamedfazalps
requested review from
AA-Turner,
AlexWaygood,
FFY00,
JelleZijlstra,
ambv,
barneygale,
emmatyping,
encukou,
erlend-aasland,
ethanfurman,
ezio-melotti,
gaogaotiantian,
giampaolo,
gpshead,
hauntsaninja,
jaraco,
kumaraditya303,
lysnikolaou,
pablogsal,
rhettinger,
terryjreedy,
vsajip and
warsaw
as code owners
muhamedfazalps
requested review from
a team,
DinoV,
Eclips4,
Fidget-Spinner,
JacobCoffee,
Yhg1s,
ZeroIntensity,
brandtbucher,
brettcannon,
diegorusso,
ericsnowcurrently,
freakboy3742,
iritkatriel,
isidentical,
itamaro,
markshannon,
mhsmith,
ncoghlan,
savannahostrowski and
webknjaz
as code owners
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RFC 2047 §5 forbids encoded-words in addr-spec. The current parser decodes them anyway via
get_dot_atom(), corrupting address parsing when the decoded text contains address-special characters (e.g.=40decodes to@).Root Cause
get_dot_atom()unconditionally decodes any=?prefix as an RFC 2047 encoded-word. When called fromget_local_part()(which is called fromget_addr_spec()), this violates RFC 2047 §5 and corrupts the parsed address.Fix
Add
ew_allowedparameter toget_dot_atom()(defaultTruefor backward compatibility). Passew_allowed=Falsewhen parsing local-parts inside addr-spec to prevent encoded-word decoding.Testing
Verified with the reproducer from the issue:
Fixes #152519
If this helps, consider buying me a coffee! https://buymeacoffee.com/muhamedfazalps