Skip to content

ci: update check for changeset workflow with local bash script#8084

Draft
Copilot wants to merge 10 commits into
mainfrom
copilot/update-check-for-changeset-dependency
Draft

ci: update check for changeset workflow with local bash script#8084
Copilot wants to merge 10 commits into
mainfrom
copilot/update-check-for-changeset-dependency

Conversation

Copilot AI commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Closes #

Recreates the changed-files changeset guard as a local GitHub Action and updates the changeset workflow to use it instead of brettcannon/check-for-changed-files@v1. The workflow now grants explicit read-only permissions and passes github.token to the local action for listing PR files.

The upstream workflow hasn't been updated for a little bit so this helps us prevent using outdated actions (was seeing the Node.js warning which is what prompted this)

Changelog

New

  • Added a local .github/actions/check-for-changed-files GitHub Action.

Changed

  • Updated .github/workflows/check_for_changeset.yml to use the local action instead of the external action.

Removed

  • Removed the workflow dependency on brettcannon/check-for-changed-files@v1.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; CI/infrastructure-only change, so no package release or changeset is needed.

Testing & Reviewing

  • Baseline before edits: npm install, npm run build, npm test -- --run, npm run type-check, npm run lint, npm run lint:css, npm run format:diff
  • Final validation: node --check .github/actions/check-for-changed-files/index.js, npx eslint .github/actions/check-for-changed-files/index.js --max-warnings=0 --cache, npm run build, npm test -- --run, npm run type-check, npm run lint, npm run lint:css, npm run format:diff
  • Smoke-tested non-PR and skip-label action paths locally.
  • Secret scanning passed for changed files.
  • Code review/CodeQL validation: initial CodeQL scan passed with 0 alerts; a later validation run timed out after review comments were returned, and the tool instructed not to rerun it. Review comments were addressed with targeted validation afterward.

Merge checklist

Copilot AI and others added 4 commits June 29, 2026 18:14
Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>
Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>
Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>
Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>
@changeset-bot

changeset-bot Bot commented Jun 29, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 7e0dde9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack joshblack left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot instead of having a script for this could it just be a bash script in the workflow?

Copilot AI and others added 4 commits June 29, 2026 20:31
Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>
Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>
Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>
Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>

Copilot AI commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

@copilot instead of having a script for this could it just be a bash script in the workflow?

Updated the PR to use an inline bash step in .github/workflows/check_for_changeset.yml and removed the local JavaScript action files. Addressed in 731fe14.

Copilot AI requested a review from joshblack June 29, 2026 20:36

@joshblack joshblack left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failure-message should be a comment on the Pull Request (and make sure to re-use one if it already exists instead of always making a new one)

@joshblack

Copy link
Copy Markdown
Member

@copilot The failure-message should be a comment on the Pull Request (and make sure to re-use one if it already exists instead of always making a new one)

Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>

Copilot AI commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

@copilot The failure-message should be a comment on the Pull Request (and make sure to re-use one if it already exists instead of always making a new one)

Addressed in c58b337 by having the workflow create or update a marked PR comment for the missing-changeset failure message.

Copilot AI requested a review from joshblack June 29, 2026 21:38
@joshblack joshblack changed the title Replace external changeset check action ci: update check for changeset workflow with local bash script Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants