Skip to content

feat: add React Compiler support for SelectPanel#8059

Open
joshblack wants to merge 2 commits into
mainfrom
copilot/react-compiler-select-panel
Open

feat: add React Compiler support for SelectPanel#8059
joshblack wants to merge 2 commits into
mainfrom
copilot/react-compiler-select-panel

Conversation

@joshblack

Copy link
Copy Markdown
Member

Closes #

Adds React Compiler support for SelectPanel by removing it from the compiler unsupported list. Updates the empty-state test fixture so it models an async empty load completing under compiler-enabled tests.

Changelog

New

  • React Compiler support for SelectPanel

Changed

  • Updated SelectPanel empty-state test coverage to be compatible with React Compiler

Removed

  • Removed SelectPanel from the React Compiler unsupported list

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

  • npx eslint --no-cache packages/react/src/SelectPanel/**/*.{ts,tsx}
  • npm test -- --run packages/react/src/SelectPanel/SelectPanel.test.tsx packages/react/src/SelectPanel/SelectPanel.types.test.tsx
  • npm run build && npm test -- --run && npm run type-check && npm run lint && npm run lint:css && npm run format:diff
  • Verified Storybook responds locally

Merge checklist

@changeset-bot

changeset-bot Bot commented Jun 25, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8a714f3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jun 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. If this doesn't work, you can also use the original workflow here. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

To publish a canary release for integration testing, apply the Canary Release label to this PR.

@joshblack joshblack marked this pull request as ready for review June 25, 2026 14:43
@joshblack joshblack requested a review from a team as a code owner June 25, 2026 14:43
@joshblack joshblack requested review from Copilot and liuliu-dev and removed request for Copilot June 25, 2026 14:43
@github-actions github-actions Bot temporarily deployed to storybook-preview-8059 June 25, 2026 14:47 Inactive
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 29, 2026 14:53
@joshblack joshblack force-pushed the copilot/react-compiler-select-panel branch from 14355bb to 8a714f3 Compare June 29, 2026 14:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request enables React Compiler support for SelectPanel by removing it from the compiler unsupported list and adjusting the empty-state test fixture to model the component’s “initial load” behavior in a compiler-compatible way.

Changes:

  • Removed SelectPanel from the React Compiler unsupportedPatterns list so it can be compiled.
  • Updated the “no items after initial load” test fixture to update items via state in response to the initial onFilterChange call, allowing SelectPanel’s internal “data loaded once” logic to complete.
  • Simplified the empty-state assertion flow by moving the click outside of waitFor and using a non-async waitFor callback.
Show a summary per file
File Description
packages/react/src/SelectPanel/SelectPanel.test.tsx Updates the empty-state test fixture to trigger an items identity change on initial load and adjusts waitFor usage for compiler-compatible async behavior.
packages/react/script/react-compiler.mjs Removes src/SelectPanel/**/*.tsx from the React Compiler unsupported list.
.changeset/react-compiler-select-panel.md Adds a patch changeset announcing React Compiler support for SelectPanel.

Review details

  • Files reviewed: 3/3 changed files
  • Comments generated: 0
  • Review effort level: Low

@primer-integration

Copy link
Copy Markdown

Integration test results from github/github-ui PR:

Failed  CI   Failed
Passed  VRT   Passed
Passed  Projects   Passed

CI check runs linting, type checking, and unit tests. Check the workflow logs for specific failures.

Need help? If you believe this failure is unrelated to your changes, please reach out to the Primer team for assistance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants