Add parameter labels for input names#11422
Draft
microbit-robert wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses the mechanism added in #11334 to create sensible input names for block inputs for screen reader users. The impact of these changes is currently limited to move mode where the block has more than one input. However, in the next Blockly release, these names will be surfaced when screen reader users focus an input via keyboard navigation. As such, I've opened this PR as a draft to provide visibility of these changes ahead of time for review and feedback.
Example of how this will work:
Current output on beta:
The parameter label creation was AI-assisted and manually reviewed.