[Subcontracting] Bug 640115: Fix Subc. Order FlowField so subcontracting orders are visible in Purchase Order List

[ChethanT]

Summary

Subcontracting purchase orders are not visible in the "Subcontracting Orders" view of the Purchase Order List because the Subc. Order FlowField always evaluates to false.

Root Cause

The CalcFormula on the Subc. Order field (field 99001521 on the Purchase Header table extension) was checking base table fields Prod. Order No. and Prod. Order Line No. on Purchase Line. These fields are not reliably populated by the Subcontracting app's own purchase order creation flow.

Fix

Changed the CalcFormula to use "Subc. Purchase Line Type" = filter(<> None), which is the extension field the Subcontracting app reliably sets. Consistent with SubcManufacturingCue.TableExt.al.

Test

Added SubcOrderFlowFieldIsTrueAfterCreatingSubcontractingPurchaseOrder (SCENARIO 640115) in codeunit 139991.

Fixes AB#640115

[github-actions]

Copilot PR Review

Iteration 7 · Outcome: completed

Knowledge source: https://github.com/microsoft/BCQuality@822cae1b2771ac25f665f73369f69093bd4fd630

Findings by domain

Findings split into Knowledge-backed (cite a BCQuality article) and Agent (the agent's own judgement, no matching BCQuality rule).

Domain	Findings	Knowledge-backed	Agent	Inline	Fallback
Style	1	1	0	1	0

Totals: 1 knowledge-backed · 0 agent findings.

Orchestrator pre-filter (13 file(s) excluded)

• layer-disabled (knowledge) : 13 file(s)

_{Findings produced by the Copilot CLI agent against BCQuality at 822cae1b2771ac25f665f73369f69093bd4fd630. Reply 👎 on any inline comment to flag false positives.}

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Style} \quad \color{gray}{\texttt{\small Iteration\ 7}}$

Variable 'FinishedItem' is referenced as 'FinishedITem' (capital I and T) on line 844, inconsistent with its declaration on line 801.

AL identifiers are case-insensitive so this compiles and runs correctly, but the casing typo reduces readability.

Recommendation:

• correct the casing to 'FinishedItem' to match the declaration.

Suggested change

	FinishedITem.Validate("Routing No.", RoutingHeader."No.");
	FinishedItem.Validate("Routing No.", RoutingHeader."No.");

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}