Forward selfFetchManagedSettings in session.create#1846
Draft
joshspicer wants to merge 1 commit into
Draft
Conversation
Add selfFetchManagedSettings to SessionConfigBase and forward it in the session.create RPC payload. This allows hosts (e.g. VS Code AHP) to opt the runtime into enterprise managed-settings self-fetch and enforcement. Without this change, the field is silently dropped by the explicit field list in client.ts and never reaches the runtime. Requires: github/copilot-agent-runtime#agents/managed-settings-sdk-capability
joshspicer
force-pushed
the
agents/managed-settings-forward-flag
branch
from
227887c to
9fdb1a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward
selfFetchManagedSettingsinsession.createThreads a new optional
selfFetchManagedSettingsflag from the SDK config through the JSON-RPCsession.create(andresumeSession) wire calls so SDK consumers can opt the runtime into self-fetching enterprise managed settings at session bootstrap.Changes
nodejs/src/types.ts— addselfFetchManagedSettings?: booleantoSessionConfigBase.nodejs/src/client.ts— forward the flag in both thesession.createandresumeSessionwire payloads.Purely additive and opt-in; unset behaves exactly as before. The runtime-side enforcement lives in the copilot-agent-runtime PR; the VS Code Agent Host opts in via the VS Code PR.
Related PRs