fix(aria/combobox): improve autocomplete placeholder text color contrast#33465
Merged
ok7sai merged 3 commits intoJul 1, 2026
Merged
Conversation
Updates Angular Aria's autocomplete styles to improve the text color contrast of the placeholder text to meet accessibilityrequirements and improve text readability. Fixes b/477617379
essjay05
added
dev-app preview
Removes redundant stylelint-disable lines.
crisbeto
approved these changes
Jun 30, 2026
crisbeto
left a comment
crisbeto
left a comment
Member
There was a problem hiding this comment.
LGTM, but worth noting that this is only used for our own internal testing AFAIK.
Updates comment in added ::placeholder styles to note the styles are primarily for internal testing.
ok7sai
added
action: merge
Member
ok7sai
pushed a commit
that referenced
this pull request
Jul 1, 2026
…ast (#33465) * fix(aria/combobox): improve autocomplete placeholder text color contrast Updates Angular Aria's autocomplete styles to improve the text color contrast of the placeholder text to meet accessibilityrequirements and improve text readability. Fixes b/477617379 * refactor(aria/combobox): fix stylelint-disable redundancy Removes redundant stylelint-disable lines. * refactor(aria/combobox): add context for reason for ::placeholder styles Updates comment in added ::placeholder styles to note the styles are primarily for internal testing. (cherry picked from commit e2cab48)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates Angular Aria's autocomplete styles to improve the text color contrast of the placeholder text to meet accessibilityrequirements and improve text readability.
Fixes b/477617379