Skip to content

[codex] skip empty vCard addresses#984

Open
chaochaoweb3 wants to merge 1 commit into
LinkStackOrg:mainfrom
chaochaoweb3:codex/skip-empty-vcard-addresses
Open

[codex] skip empty vCard addresses#984
chaochaoweb3 wants to merge 1 commit into
LinkStackOrg:mainfrom
chaochaoweb3:codex/skip-empty-vcard-addresses

Conversation

@chaochaoweb3

Copy link
Copy Markdown

Summary

  • skip HOME and WORK address entries when all address fields are blank
  • keep existing vCard output unchanged when any address field is present

Why

The vCard endpoint always called addAddress() for HOME and WORK. On iOS this can create empty HOME/WORK address entries, making the device try to resolve a location from just the label.

Fixes #961.

Validation

  • git diff --check
  • php -l app/Http/Controllers/UserController.php not run: PHP is not installed in this local environment

@chaochaoweb3 chaochaoweb3 force-pushed the codex/skip-empty-vcard-addresses branch from 3213470 to b738ea5 Compare June 30, 2026 05:17
@chaochaoweb3 chaochaoweb3 marked this pull request as ready for review June 30, 2026 05:24
@chaochaoweb3

Copy link
Copy Markdown
Author

Rebased this onto the latest upstream main, corrected the commit author metadata, and marked it ready for review. I also triggered a fresh Scrutinizer run; it still reports repository-level analysis errored / tests failed with no artifacts exposed, and the Scrutinizer API shows the tracked main build is already failed. Local validation available here was git diff --check.

@JulianPrieber

Copy link
Copy Markdown
Member

Thank you. I will check this soon.
Scrutinizer is having some problems with the mainline build.

Ideally we'll test this in the beta build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vCard populates blank HOME and WORK addresses when no data is provided

2 participants