Skip to content

🔒 fix: secure /health endpoint against unauthorized access#317

Closed
max-ostapenko wants to merge 1 commit into
mainfrom
fix-health-auth-11187011909452902925
Closed

🔒 fix: secure /health endpoint against unauthorized access#317
max-ostapenko wants to merge 1 commit into
mainfrom
fix-health-auth-11187011909452902925

Conversation

@max-ostapenko

Copy link
Copy Markdown
Contributor

🎯 What: Secured the /health endpoint by restricting access. It now returns 403 Forbidden unless the request originates from localhost (127.0.0.1, ::1) or contains a GoogleHC User-Agent (used by Cloud Run infrastructure probes).

⚠️ Risk: While a /health endpoint is generally lightweight, leaving it unauthenticated and open allows potential attackers to perform service discovery and map the service's footprint. Additionally, the previous unverified setup could be more vulnerable to Denial-of-Service attacks if the endpoint performs more intensive background checks.

🛡️ Solution: Added a security check in index.js that inspects the remote address and User-Agent. It allows legitimate local Docker health checks and Cloud Run platform probes, but denies external traffic. Removed insecure logic that attempted to parse client IPs from the spoofable X-Forwarded-For header.


PR created automatically by Jules for task 11187011909452902925 started by @max-ostapenko

Restricts the `/health` endpoint to only allow local loopback IPs or the Google Cloud health check agent (`GoogleHC`), preventing external probing or automated scanning.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@max-ostapenko max-ostapenko deleted the fix-health-auth-11187011909452902925 branch June 28, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant